Skip to content

Commit 39dcf16

Browse files
Fix: Log accessory names not futures (#151)
The previous code logged the CompletableFuture, not the name of the accessory. Fixes #150
1 parent f4a9872 commit 39dcf16

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

CHANGES.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# HAP-Java 2.0.1
2+
## Fixes
3+
* Log accessory names instead of futures. [#150](https://github.com/hap-java/HAP-Java/issues/150)
4+
15
# HAP-Java 2.0.0
26
* major refactoring to support optional characteristics
37
* structure and names adapted to HAP spec structure and naming.

src/main/java/io/github/hapjava/server/impl/HomekitRoot.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,9 @@ public void addAccessory(HomekitAccessory accessory) {
8383
*/
8484
void addAccessorySkipRangeCheck(HomekitAccessory accessory) {
8585
this.registry.add(accessory);
86-
logger.trace("Added accessory " + accessory.getName());
86+
if (logger.isTraceEnabled()) {
87+
accessory.getName().thenAccept(name -> logger.trace("Added accessory {}", name));
88+
}
8789
if (started) {
8890
registry.reset();
8991
webHandler.resetConnections();
@@ -99,7 +101,9 @@ void addAccessorySkipRangeCheck(HomekitAccessory accessory) {
99101
*/
100102
public void removeAccessory(HomekitAccessory accessory) {
101103
this.registry.remove(accessory);
102-
logger.trace("Removed accessory " + accessory.getName());
104+
if (logger.isTraceEnabled()) {
105+
accessory.getName().thenAccept(name -> logger.trace("Removed accessory {}", name));
106+
}
103107
if (started) {
104108
registry.reset();
105109
webHandler.resetConnections();

0 commit comments

Comments
 (0)