This repository was archived by the owner on Jul 6, 2019. It is now read-only.
6/23 Nightly fallout #317
Merged
6/23 Nightly fallout #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcoffin
added
in progress
ready for review
nightly fallout
and removed
ready for review
in progress
labels
|
Apparently something is still broken with the linking any app that ends up using |
|
retest this please |
Merged
farcaller
added a commit
that referenced
this pull request
Jul 2, 2015
6/23 Nightly fallout, fixes #317
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from_strdeprecated in favor ofFrom<T>.sort_bytakes a comparison fn, butmin_by/max_bytake a "scoring" fn rust-lang/rust#15311 caused possible rethinking ofmax_byandmin_byon iterators.Vec::push_allfeature-gated, but I replaced it so that we don't depend on another unstable feature.It looks like it's a long road ahead before zinc will be able to track the stable channel or Rust.