updates required for go 1.18 #2
Conversation
|
@mlctrez Saved my day, I also encountered the same problem and guide me to the same issue. thanks |
| @@ -1,3 +1,3 @@ | |||
| module github.com/hack-pad/go-indexeddb | |||
|
|
|||
| go 1.16 | |||
| go 1.18 | |||
There was a problem hiding this comment.
I'd like to revert this piece, since this requires all modules that import go-indexeddb to use Go 1.18 or higher. I'll add go test runs to ensure it's forward-compatible with Go 1.18 too.
| // JSValue implements js.Wrapper | ||
| func (k *KeyRange) JSValue() js.Value { | ||
| return k.jsKeyRange | ||
| } | ||
| // removed see : https://github.com/golang/go/issues/44006 |
There was a problem hiding this comment.
Let's try to keep the struct field private (i.e. not embedded) and switch to using k.jsKeyRange.
Since we're in the same package and can't use the old js.Wrapper, we don't need to export it anymore. 👍 We can remove this old doc comment too.
This is technically a breaking change, so I'll mark the release of this change with a v0.x minor version bump.
|
Merged via #3 |
|
Released in |
This PR contains the changes required to allow go-indexeddb to work with go 1.18
golang/go#44006 removed js.Wrapper
KeyRange type is now passed as keyRange.Value in Calls
js.ValueOf now appears to be a bit more strict on types
Various types like CursorDirection are now passed using .String() to Calls