Skip to content

Commit 009373d

Browse files
author
Guy Bedford
committed
update to latest v8
1 parent 98b0d48 commit 009373d

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

src/module_wrap.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,10 +1019,8 @@ void ModuleWrap::SetImportModuleDynamicallyCallback(
10191019
realm->set_host_import_module_dynamically_callback(import_callback);
10201020

10211021
isolate->SetHostImportModuleDynamicallyCallback(ImportModuleDynamically);
1022-
// TODO(guybedford): Enable this once
1023-
// https://github.com/nodejs/node/pull/56842 lands.
1024-
// isolate->SetHostImportModuleWithPhaseDynamicallyCallback(
1025-
// ImportModuleDynamicallyWithPhase);
1022+
isolate->SetHostImportModuleWithPhaseDynamicallyCallback(
1023+
ImportModuleDynamicallyWithPhase);
10261024
}
10271025

10281026
void ModuleWrap::HostInitializeImportMetaObjectCallback(Local<Context> context,

test/es-module/test-esm-wasm.mjs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,7 @@ describe('ESM: WASM modules', { concurrency: !process.env.TEST_PARALLEL }, () =>
112112
strictEqual(code, 0);
113113
});
114114

115-
// TODO: Enable this once https://github.com/nodejs/node/pull/56842 lands.
116-
it.skip('should support dynamic source phase imports', async () => {
115+
it('should support dynamic source phase imports', async () => {
117116
const { code, stderr, stdout } = await spawnPromisified(execPath, [
118117
'--no-warnings',
119118
'--experimental-wasm-modules',
@@ -153,8 +152,7 @@ describe('ESM: WASM modules', { concurrency: !process.env.TEST_PARALLEL }, () =>
153152
strictEqual(code, 0);
154153
});
155154

156-
// TODO: Enable this once https://github.com/nodejs/node/pull/56842 lands.
157-
it.skip('should not execute dynamic source phase imports', async () => {
155+
it('should not execute dynamic source phase imports', async () => {
158156
const { code, stderr, stdout } = await spawnPromisified(execPath, [
159157
'--no-warnings',
160158
'--experimental-wasm-modules',
@@ -168,8 +166,7 @@ describe('ESM: WASM modules', { concurrency: !process.env.TEST_PARALLEL }, () =>
168166
strictEqual(code, 0);
169167
});
170168

171-
// TODO: Enable this once https://github.com/nodejs/node/pull/56842 lands.
172-
it.skip('should throw for dynamic source phase imports not defined', async () => {
169+
it('should throw for dynamic source phase imports not defined', async () => {
173170
const fileUrl = fixtures.fileURL('es-modules/wasm-source-phase.js');
174171
const { code, stderr, stdout } = await spawnPromisified(execPath, [
175172
'--no-warnings',
@@ -225,8 +222,7 @@ describe('ESM: WASM modules', { concurrency: !process.env.TEST_PARALLEL }, () =>
225222
notStrictEqual(code, 0);
226223
});
227224

228-
// TODO: Enable this once https://github.com/nodejs/node/pull/56842 lands.
229-
it.skip('should throw for vm source phase dynamic import', async () => {
225+
it('should throw for vm source phase dynamic import', async () => {
230226
const { code, stderr, stdout } = await spawnPromisified(execPath, [
231227
'--no-warnings',
232228
'--experimental-wasm-modules',

0 commit comments

Comments
 (0)