This repository was archived by the owner on Jun 8, 2021. It is now read-only.
Wrappers evolution #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trait is implemented for types themselves now instead of references.
* `Object` is based on `Refcounted` now. * Upcasts are implicit in `ToGlibPtr` implementations now removing the need to call `upcast`. * The `Upcast` trait is essentially a shorthand for the presence of the appropriate `ToGlibPtr` implementations. * `downcast_unchecked` is unsafe with its `assert` changed to `debug_assert`.
Add conversions to/from `ObjectRef`. This simplifies `Downcast` bounds and implementation.
This was referenced Nov 25, 2015
| @@ -1,6 +1,6 @@ | |||
| language: rust | |||
| rust: | |||
| - beta | |||
| - nightly | |||
There was a problem hiding this comment.
Maybe we should just add beta too once and for all since it seems to work. Like this, all three stages will be tested. That's not very useful but whatever...
There was a problem hiding this comment.
Yeah I guess there's no harm in having beta too.
|
Except for build targets, all seems ok. That's a very impressive work, thanks a lot for this ! |
|
Perfect, examples will need to be updated too. Wanna do it ? |
|
I don't think examples are affected, the build breaks because the other two PRs and this one are mutually dependent. |
|
Ok, then let's merge ! :D |
homu
added a commit
to gtk-rs/gir
that referenced
this pull request
Nov 25, 2015
Wrappers evolution Follows the changes in gtk-rs/glib#77
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refcountedwrapper.Objectwrapper viaRefcounted.ToGlibPtrfor saner implementations."Reformed" branches: gtk-rs/gdk#84 and gtk