Skip to content

Commit c4c4f34

Browse files
author
Emmanuel Garcia
authored
Wait for first frame before checking layer tree (flutter#20910)
1 parent 5f49a95 commit c4c4f34

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

shell/common/shell_unittests.cc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -599,13 +599,11 @@ TEST_F(ShellTest,
599599

600600
TEST_F(ShellTest, OnPlatformViewDestroyDisablesThreadMerger) {
601601
auto settings = CreateSettingsForFixture();
602-
fml::AutoResetWaitableEvent end_frame_latch;
603602
fml::RefPtr<fml::RasterThreadMerger> raster_thread_merger;
604603
auto end_frame_callback =
605604
[&](bool should_resubmit_frame,
606605
fml::RefPtr<fml::RasterThreadMerger> thread_merger) {
607606
raster_thread_merger = thread_merger;
608-
end_frame_latch.Signal();
609607
};
610608
auto external_view_embedder = std::make_shared<ShellTestExternalViewEmbedder>(
611609
end_frame_callback, PostPrerollResult::kSuccess, true);
@@ -639,7 +637,10 @@ TEST_F(ShellTest, OnPlatformViewDestroyDisablesThreadMerger) {
639637

640638
PumpOneFrame(shell.get(), 100, 100, builder);
641639

642-
end_frame_latch.Wait();
640+
auto result =
641+
shell->WaitForFirstFrame(fml::TimeDelta::FromMilliseconds(1000));
642+
ASSERT_TRUE(result.ok());
643+
643644
ASSERT_TRUE(raster_thread_merger->IsEnabled());
644645

645646
ValidateDestroyPlatformView(shell.get());

0 commit comments

Comments
 (0)