Allow kt_jvm_proto_library to have java_proto_library dep. #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the same argument naming as in `kt_jvm_grpc_library`. Not touching that rule, as it already depend on a `java_proto_library`, though still not the right way, as it still always do the java_grpc_library building in addition... Not sure how to handle that rule in a similar way... Though that library rule handles the build-caching better it seems, so less of an issue.
|
Messy change with lots of "ifs" and conditional parameters to rules. So dropping this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same argument naming as in
kt_jvm_grpc_library. Not touching that rule, as it already depend on ajava_proto_library, though still not the right way, as it still always do the java_grpc_library building in addition... Not sure how to handle that rule in a similar way...Though that library rule handles the build-caching better it seems, so less of an issue.