xds: temporary flag protection of GcpAuthenticationFilter #12075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kannanjgithub
approved these changes
May 16, 2025
shivaspeaks
changed the title
| @@ -32,12 +33,19 @@ final class FilterRegistry { | |||
|
|
|||
| private FilterRegistry() {} | |||
|
|
|||
| public static boolean isEnabledGcpAuthnFilter() { | |||
| return GrpcUtil.getFlag("GRPC_EXPERIMENTAL_XDS_GCP_AUTHENTICATION_FILTER", false); | |||
There was a problem hiding this comment.
We can avoid making this method call and have it static initialized by creating a package-private access static (non-final) variable and set its value in the unit test directly instead of using System.setProperty. Example.
| @@ -2417,6 +2417,7 @@ public Object parse(Any value) { | |||
|
|
|||
| @Test | |||
| public void processCluster_parsesAudienceMetadata() throws Exception { | |||
| FilterRegistry.isEnabledGcpAuthnFilter = true; | |||
There was a problem hiding this comment.
Use try - finally to undo this setting before the test exits. Example
Also in the other test case.
shivaspeaks
added a commit
to shivaspeaks/grpc-java
that referenced
this pull request
May 22, 2025
shivaspeaks
added a commit
to shivaspeaks/grpc-java
that referenced
this pull request
May 23, 2025
shivaspeaks
added a commit
that referenced
this pull request
May 23, 2025
kannanjgithub
pushed a commit
that referenced
this pull request
May 23, 2025
AgraVator
pushed a commit
to AgraVator/grpc-java
that referenced
this pull request
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing and final piece of gRFC A83-xds-gcp-authn-filter.md