-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Android: Add failOnWarnings check to android build.gradle and configure lint as warnings as error #12040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Sangamesh1997
wants to merge
8
commits into
grpc:master
Choose a base branch
from
Sangamesh1997:Issue_fixed_6868
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Android: Add failOnWarnings check to android build.gradle and configure lint as warnings as error #12040
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2bf4968
Android: Add failOnWarnings check to android build.gradle and configu…
Sangamesh1997 c571f77
android: added white space
Sangamesh1997 dbfe6d4
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 148c017
Android : added review comments point
Sangamesh1997 f9a0fde
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 85a6ba6
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 94f92f6
Android : added review comments point
Sangamesh1997 6d3f981
Merge branch 'grpc:master' into Issue_fixed_6868
Sangamesh1997 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be within a
plugins.withId()
section.