xds: propagate audience from cluster resource in gcp auth filter #11972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

shivaspeaks merged 8 commits into grpc:master from shivaspeaks:connect_audience_in_gcp_filter

Apr 2, 2025

Member

shivaspeaks commented Mar 21, 2025

No description provided.


          xds: propagate audience from cluster resource in gcp auth filter

3b9f264

shivaspeaks requested review from ejona86, kannanjgithub and larry-safran

March 21, 2025 09:37

Member Author

shivaspeaks commented Mar 21, 2025

I'm working on fixing the unit tests. Until then please take a look and provide suggestions/ improvements.

kannanjgithub reviewed

View reviewed changes

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

kannanjgithub requested changes

View reviewed changes

Contributor

kannanjgithub left a comment

Review comments.

ejona86 reviewed

View reviewed changes

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved


          address comments

f2dffe4

shivaspeaks requested review from ejona86 and kannanjgithub

March 25, 2025 14:27

ejona86 reviewed

View reviewed changes

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Show resolved Hide resolved


          address comments

cf09105

shivaspeaks marked this pull request as ready for review

March 25, 2025 17:50

shivaspeaks requested a review from ejona86

March 25, 2025 17:50

ejona86 reviewed

View reviewed changes

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

shivaspeaks added 2 commits

March 26, 2025 06:01


          address comments

e6be504


          address comments and add test for failure cases

bcec5d0

shivaspeaks requested a review from ejona86

March 26, 2025 15:58

ejona86 approved these changes

View reviewed changes

kannanjgithub reviewed

View reviewed changes

xds/src/main/java/io/grpc/xds/GcpAuthenticationFilter.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub requested changes

View reviewed changes

Contributor

kannanjgithub left a comment

Review comments.


          Fix unit tests

0236a04

shivaspeaks requested a review from kannanjgithub

April 1, 2025 17:10

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Outdated Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Show resolved Hide resolved

kannanjgithub requested changes

View reviewed changes

Contributor

kannanjgithub left a comment

Review comments.


          fix unit tests

a845f3d

shivaspeaks requested a review from kannanjgithub

April 2, 2025 08:58

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Show resolved Hide resolved

kannanjgithub reviewed

View reviewed changes

xds/src/test/java/io/grpc/xds/GcpAuthenticationFilterTest.java Show resolved Hide resolved

kannanjgithub requested changes

View reviewed changes

Contributor

kannanjgithub left a comment

Some minor comments.


          fix unit tests

e64df5d

shivaspeaks requested a review from kannanjgithub

April 2, 2025 10:06

kannanjgithub requested changes

View reviewed changes

Contributor

kannanjgithub left a comment

Forgot the catching runtime exception comment.

kannanjgithub approved these changes

View reviewed changes

shivaspeaks merged commit 84c7713 into grpc:master

16 checks passed

shivaspeaks deleted the connect_audience_in_gcp_filter branch

April 2, 2025 11:00

Sangamesh1997 pushed a commit to Sangamesh1997/grpc-java that referenced this pull request


          xds: propagate audience from cluster resource in gcp auth filter (grp…

0ab9e11

…c#11972)

shivaspeaks added a commit to shivaspeaks/grpc-java that referenced this pull request


          xds: propagate audience from cluster resource in gcp auth filter (grp…

40f2a9e

…c#11972)

shivaspeaks mentioned this pull request

xds: propagate audience from cluster resource in gcp auth filter (v1.72.x backport) #12088

Merged

shivaspeaks added a commit that referenced this pull request


          xds: propagate audience from cluster resource in gcp auth filter (#11972

a2e53f6

) (#12088)

shivaspeaks mentioned this pull request

xds: propagate audience from cluster resource in gcp auth filter (v1.71.x backport) #12100

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet