Skip to content

Commit f168a61

Browse files
#9179 - allow selecting jakarta/javax Generated annotation
1 parent 0f21574 commit f168a61

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

compiler/src/java_plugin/cpp/java_generator.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1217,7 +1217,8 @@ void PrintImports(Printer* p) {
12171217
void GenerateService(const ServiceDescriptor* service,
12181218
protobuf::io::ZeroCopyOutputStream* out,
12191219
ProtoFlavor flavor,
1220-
bool disable_version) {
1220+
bool disable_version,
1221+
bool jakarta_over_javax) {
12211222
// All non-generated classes must be referred by fully qualified names to
12221223
// avoid collision with generated classes.
12231224
std::map<std::string, std::string> vars;
@@ -1249,7 +1250,9 @@ void GenerateService(const ServiceDescriptor* service,
12491250
vars["MethodDescriptor"] = "io.grpc.MethodDescriptor";
12501251
vars["StreamObserver"] = "io.grpc.stub.StreamObserver";
12511252
vars["Iterator"] = "java.util.Iterator";
1252-
vars["Generated"] = "javax.annotation.Generated";
1253+
vars["Generated"] = jakarta_over_javax
1254+
? "javax.annotation.Generated"
1255+
: "jakarta.annotation.Generated";
12531256
vars["GrpcGenerated"] = "io.grpc.stub.annotations.GrpcGenerated";
12541257
vars["ListenableFuture"] =
12551258
"com.google.common.util.concurrent.ListenableFuture";

compiler/src/java_plugin/cpp/java_generator.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,8 @@ std::string ServiceClassName(const impl::protobuf::ServiceDescriptor* service);
6868
void GenerateService(const impl::protobuf::ServiceDescriptor* service,
6969
impl::protobuf::io::ZeroCopyOutputStream* out,
7070
ProtoFlavor flavor,
71-
bool disable_version);
71+
bool disable_version,
72+
bool jakarta_over_javax);
7273

7374
} // namespace java_grpc_generator
7475

compiler/src/java_plugin/cpp/java_plugin.cpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,12 +59,15 @@ class JavaGrpcGenerator : public protobuf::compiler::CodeGenerator {
5959
java_grpc_generator::ProtoFlavor flavor =
6060
java_grpc_generator::ProtoFlavor::NORMAL;
6161

62+
bool jakarta_over_javax = false;
6263
bool disable_version = false;
6364
for (size_t i = 0; i < options.size(); i++) {
6465
if (options[i].first == "lite") {
6566
flavor = java_grpc_generator::ProtoFlavor::LITE;
6667
} else if (options[i].first == "noversion") {
6768
disable_version = true;
69+
} else if (options[i].first == "jakarta") {
70+
jakarta_over_javax = true;
6871
}
6972
}
7073

@@ -77,7 +80,7 @@ class JavaGrpcGenerator : public protobuf::compiler::CodeGenerator {
7780
std::unique_ptr<protobuf::io::ZeroCopyOutputStream> output(
7881
context->Open(filename));
7982
java_grpc_generator::GenerateService(
80-
service, output.get(), flavor, disable_version);
83+
service, output.get(), flavor, disable_version, jakarta_over_javax);
8184
}
8285
return true;
8386
}

0 commit comments

Comments
 (0)