@@ -99,12 +99,11 @@ func (s) TestBlockingPickNoSubAvailable(t *testing.T) {
9999 bp := newPickerWrapper (nil )
100100 var finishedCount uint64
101101 bp .updatePicker (& testingPicker {err : balancer .ErrNoSubConnAvailable , maxCalled : goroutineCount })
102+ ctx , cancel := context .WithTimeout (context .Background (), defaultTestTimeout )
103+ defer cancel ()
102104 // All goroutines should block because picker returns no subConn available.
103105 for i := goroutineCount ; i > 0 ; i -- {
104106 go func () {
105- ctx , cancel := context .WithTimeout (context .Background (), defaultTestTimeout )
106- defer cancel ()
107-
108107 if tr , _ , err := bp .pick (ctx , true , balancer.PickInfo {}); err != nil || tr != testT {
109108 t .Errorf ("bp.pick returned non-nil error: %v" , err )
110109 }
@@ -122,13 +121,12 @@ func (s) TestBlockingPickTransientWaitforready(t *testing.T) {
122121 bp := newPickerWrapper (nil )
123122 bp .updatePicker (& testingPicker {err : balancer .ErrTransientFailure , maxCalled : goroutineCount })
124123 var finishedCount uint64
124+ ctx , cancel := context .WithTimeout (context .Background (), defaultTestTimeout )
125+ defer cancel ()
125126 // All goroutines should block because picker returns transientFailure and
126127 // picks are not failfast.
127128 for i := goroutineCount ; i > 0 ; i -- {
128129 go func () {
129- ctx , cancel := context .WithTimeout (context .Background (), defaultTestTimeout )
130- defer cancel ()
131-
132130 if tr , _ , err := bp .pick (ctx , false , balancer.PickInfo {}); err != nil || tr != testT {
133131 t .Errorf ("bp.pick returned non-nil error: %v" , err )
134132 }
@@ -146,12 +144,11 @@ func (s) TestBlockingPickSCNotReady(t *testing.T) {
146144 bp := newPickerWrapper (nil )
147145 bp .updatePicker (& testingPicker {sc : testSCNotReady , maxCalled : goroutineCount })
148146 var finishedCount uint64
147+ ctx , cancel := context .WithTimeout (context .Background (), defaultTestTimeout )
148+ defer cancel ()
149149 // All goroutines should block because subConn is not ready.
150150 for i := goroutineCount ; i > 0 ; i -- {
151151 go func () {
152- ctx , cancel := context .WithTimeout (context .Background (), defaultTestTimeout )
153- defer cancel ()
154-
155152 if tr , _ , err := bp .pick (ctx , true , balancer.PickInfo {}); err != nil || tr != testT {
156153 t .Errorf ("bp.pick returned non-nil error: %v" , err )
157154 }
0 commit comments