Improve Stringer interface on acBalancerWrapper to allow human identification of which SubConn is used

AnomalRoil · AnomalRoil · commit 001f394f81ec · 2024-04-22T21:41:24.000+02:00
Protect access to curAddr with ac.mutex

Signed-off-by: Yolan Romailler &lt;anomalroil@users.noreply.github.com&gt;
diff --git a/balancer_wrapper.go b/balancer_wrapper.go
@@ -261,7 +261,9 @@ func (acbw *acBalancerWrapper) updateState(s connectivity.State, err error) {
 }
 
 func (acbw *acBalancerWrapper) String() string {
-	return fmt.Sprintf("SubConn(id:%d)", acbw.ac.channelz.ID)
+	acbw.ac.mu.Lock()
+	defer acbw.ac.mu.Unlock()
+	return fmt.Sprintf("SubConn(id:%d;addr:%s)", acbw.ac.channelz.ID, acbw.ac.curAddr.Addr)
 }
 
 func (acbw *acBalancerWrapper) UpdateAddresses(addrs []resolver.Address) {

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,9 @@ func (acbw *acBalancerWrapper) updateState(s connectivity.State, err error) {`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`func (acbw *acBalancerWrapper) String() string {`
`264`		`- return fmt.Sprintf("SubConn(id:%d)", acbw.ac.channelz.ID)`
	`264`	`+ acbw.ac.mu.Lock()`
	`265`	`+ defer acbw.ac.mu.Unlock()`
	`266`	`+ return fmt.Sprintf("SubConn(id:%d;addr:%s)", acbw.ac.channelz.ID, acbw.ac.curAddr.Addr)`
`265`	`267`	`}`
`266`	`268`
`267`	`269`	`func (acbw *acBalancerWrapper) UpdateAddresses(addrs []resolver.Address) {`