Move DateTimeStrFormat to make clang happy for MacOS compiles.

Author: jamescowens

src/logging.cpp

@@ -18,7 +18,6 @@
 
 // Unavoidable because these are in util.h.
 extern fs::path &GetDataDir(bool fNetSpecific);
-extern std::string DateTimeStrFormat(const char* pszFormat, int64_t nTime);
 extern bool GetBoolArg(const std::string& strArg, bool fDefault);
 extern int64_t GetArg(const std::string& strArg, int64_t nDefault);
 

src/logging.h

@@ -31,6 +31,21 @@ extern bool fLogIPs;
 // Unavoidable because this is in util.h.
 extern int64_t GetAdjustedTime();
 
+inline std::string DateTimeStrFormat(const char* pszFormat, int64_t nTime)
+{
+    time_t n = nTime;
+    struct tm* ptmTime = gmtime(&n);
+    char pszTime[200];
+    strftime(pszTime, sizeof(pszTime), pszFormat, ptmTime);
+    return pszTime;
+}
+
+static const std::string strTimestampFormat = "%Y-%m-%d %H:%M:%S UTC";
+inline std::string DateTimeStrFormat(int64_t nTime)
+{
+    return DateTimeStrFormat(strTimestampFormat.c_str(), nTime);
+}
+
 struct CLogCategoryActive
 {
     std::string category;

src/util.h

@@ -275,21 +275,6 @@ inline int64_t GetPerformanceCounter()
     return nCounter;
 }
 
-inline std::string DateTimeStrFormat(const char* pszFormat, int64_t nTime)
-{
-    time_t n = nTime;
-    struct tm* ptmTime = gmtime(&n);
-    char pszTime[200];
-    strftime(pszTime, sizeof(pszTime), pszFormat, ptmTime);
-    return pszTime;
-}
-
-static const std::string strTimestampFormat = "%Y-%m-%d %H:%M:%S UTC";
-inline std::string DateTimeStrFormat(int64_t nTime)
-{
-    return DateTimeStrFormat(strTimestampFormat.c_str(), nTime);
-}
-
 inline bool IsSwitchChar(char c)
 {
 #ifdef WIN32