Adjust locking in ScraperConstructConvergedManifestByProject

Author: jamescowens

src/gridcoin/scraper/scraper.cpp

@@ -4982,8 +4982,6 @@ bool ScraperConstructConvergedManifestByProject(const WhitelistSnapshot& project
 
     StructConvergedManifest.CScraperConvergedManifest_ptr = std::shared_ptr<CScraperManifest>(new CScraperManifest);
 
-    LOCK(StructConvergedManifest.CScraperConvergedManifest_ptr->cs_manifest);
-
     // We are going to do this for each project in the whitelist.
     unsigned int iCountSuccessfulConvergedProjects = 0;
     unsigned int nScraperCount = mMapCSManifestsBinnedByScraper.size();
@@ -5237,6 +5235,8 @@ bool ScraperConstructConvergedManifestByProject(const WhitelistSnapshot& project
 
             // The BeaconList is element 0, do that first.
             {
+                LOCK(StructConvergedManifest.CScraperConvergedManifest_ptr->cs_manifest);
+
                 auto iter = StructConvergedManifest.ConvergedManifestPartPtrsMap.find("BeaconList");
 
                 StructConvergedManifest.CScraperConvergedManifest_ptr->addPart(iter->second->hash);