Prevent pasting (no label) as label in consolidation transaction

Author: jamescowens

src/qt/sendcoinsdialog.cpp

@@ -490,8 +490,6 @@ void SendCoinsDialog::coinControlConsolidateWizardButtonClicked()
 
 void SendCoinsDialog::selectedConsolidationRecipient(SendCoinsRecipient consolidationRecipient)
 {
-    LogPrintf("INFO: %s: SLOT called.", __func__);
-
     ui->coinControlChangeCheckBox->setChecked(true);
     ui->coinControlChangeEdit->setText(consolidationRecipient.address);
 
@@ -505,6 +503,12 @@ void SendCoinsDialog::selectedConsolidationRecipient(SendCoinsRecipient consolid
         }
     }
 
+    // The AddressTableModel substitutes the translated "(no label)" when the label is empty. If we use
+    // that here, we will end up pasting a literal lable of "(no label)". Because the translation (tr) should
+    // be consistent between here and the AddressTableModel::data, it should match the conditional and be put
+    // back to the desired empty QString.
+    if (consolidationRecipient.label == tr("(no label)")) consolidationRecipient.label = QString();
+
     pasteEntry(consolidationRecipient);
 }