Update dependencies #940
Update dependencies #940
Conversation
There was a problem hiding this comment.
We can use the new JSX transform. React team provides a codemod to remove all import React from ‘react’
|
Do you want to do the transformed @ardatan? I don't end either way |
|
I was afraid of breaking things. Let's leave it in a different PR. |
|
We could have used this new transform syntax in #938 since that was a feature added in v16.14 but I missed to point that out in review. According to release blog post. They changed event delegation and a few other non breaking issues. I don’t think any of the changes will affect us. Purpose of this version is to make it easier to gradually upgrade react’s future versions. Sure we can get that in a new PR |
|
I've reviewed and everything works as expected so I'm merging, but that doesn't mean we shouldn't move to the new JSX transform as @saihaj suggested! @saihaj that's a good idea, are you up to creating a new PR with the new transform? |
|
I can get something in today |
|
@Urigo turns out gatsby has disabled automatic JSX runtime temporarily gatsbyjs/gatsby#27615. We need to wait for a new Gatsby release before we refactor. |
Update dependencies
Update dependencies
* sync 20201029 * cherrypick: Gatsby Migration * cherrypick: More changes * Fix Learn sidebar * Fix issues * Fix search bar jumping issue * Fix links at home page * Add netlify.toml file * Fix key prop issues * bring back notes * Fix search for gatsby site * move Chinese to new index page * site meta * Merge pull request graphql#940 from ardatan/update-dependencies Update dependencies * chore(deps): update dependencies * Sync 20201112 Co-authored-by: Arda TANRIKULU <[email protected]> Co-authored-by: Orta <[email protected]>
No description provided.