Skip to content

Clean up useEffect animations (Gatsby) #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Clean up useEffect animations (Gatsby) #934

wants to merge 1 commit into from

Conversation

mikeesto
Copy link
Contributor

Resolves:

Fix animations in pages/index.js: useEffect hook is used to run the animations but the problem is when page changes it still runs for some reason and I don't know how to fix it. Update: I tried a clean up function to remove the child nodes but no good.

In #913 (comment)

There's some good discussion in #790 about using CSS or GIFs/videos for the animations. This is more a bandaid fix!

@carolstran carolstran added 🐛 Bug 👾 Gatsby Related to the Gatsby migration labels Oct 17, 2020
carolstran
carolstran approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this as a temporary fix! Especially as we have an issue open about CSS animations already. Pinging @IvanGoncharov to review before merging 🕺🏼

Thank you @mikeesto!

@Urigo
Copy link
Contributor

Urigo commented Oct 20, 2020

Thank you @mikeesto !
We've integrated it into #936
Could you review and make sure it work good there?

Thanks

@mikeesto
Copy link
Contributor Author

mikeesto commented Nov 3, 2020

Thanks @Urigo . This has been merged in #938 so I'm closing this.

@mikeesto mikeesto closed this Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolstran carolstran carolstran approved these changes

@IvanGoncharov IvanGoncharov Awaiting requested review from IvanGoncharov

Assignees
No one assigned
Labels
🐛 Bug 👾 Gatsby Related to the Gatsby migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikeesto @Urigo @carolstran