Skip to content

updated code to include caliban #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

updated code to include caliban #927

wants to merge 7 commits into from

Conversation

8bitreid
Copy link

@8bitreid 8bitreid commented Oct 7, 2020

Adding Caliban to the code examples.

@carolstran
Copy link
Member

👋🏼 Thanks for taking the time to open this pull request! We're currently re-evaluating how we handle contributions to this Code page and pausing any changes until after those decisions are made. So I'm going to mark this PR as On hold and if you have any thoughts on this topic, it'd be great if you could voice them in #911

@carolstran
Copy link
Member

Hey hey 👋🏼 the Gatsby migration (#938) has been merged so now we can update the content again. Could you please resolve the conflicts on your branch?

@8bitreid
Copy link
Author

8bitreid commented Nov 3, 2020

@carolstran please take a look 👍🏻

Copy link
Member

@carolstran carolstran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for contributing! I added a small note.

Also pinging @IvanGoncharov and @orta because I don't know the protocol for which libraries should have longer examples. So far it seems like we have one per programming language and Scala already has Sangria.

@@ -586,6 +586,48 @@ val query = graphql"{ hello }"
Executor.execute(schema, query) map println
```

#### [Caliban](https://ghostdogpr.github.io/caliban/) ([github](https://github.com/ghostdogpr/caliban)): Caliban is a purely functional library for building GraphQL servers and clients in Scala

A simple example of a GraphQL schema and query with \`caliban\`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't love the word simple here (here's a good talk from Jim Fisher that explains why). Maybe instead, it could briefly summarize what's happening in the schema/query?

@ardatan ardatan mentioned this pull request Nov 16, 2020
@orta
Copy link
Member

orta commented Nov 18, 2020

I'm going to close this PR as these changes were manually merged upstream by @ardatan in #936 - thanks for updating the list.

Note: We now have markdown files which allow for longer descriptions on the new code page: https://graphql.org/code/ - so it'd be awesome if you added some code samples etc to help any project on the page shine.

@orta orta closed this Nov 18, 2020
@8bitreid
Copy link
Author

I'm going to close this PR as these changes were manually merged upstream by @ardatan in #936 - thanks for updating the list.

Note: We now have markdown files which allow for longer descriptions on the new code page: https://graphql.org/code/ - so it'd be awesome if you added some code samples etc to help any project on the page shine.

@orta thanks for getting this change in the other PR.. however you put Caliban in Swift, when it a Scala project.. I'll put a PR to fix that.

@8bitreid 8bitreid mentioned this pull request Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants