Skip to content

show active status on navbar #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

toshihidetagami
Copy link

Description

Right now except "code", active status is not shown on the navbar. Therefore, visitors can't see which page there are on.
This fix will show active status on "Learn", "Community", "Code of Conduct".

Screenshot

Before the fix

Learn
Screen Shot 2020-03-25 at 10 55 47 PM

Community
Screen Shot 2020-03-25 at 10 56 21 PM

Code of Conduct
Screen Shot 2020-03-25 at 10 56 32 PM

After the fix

Learn
Screen Shot 2020-03-25 at 11 00 03 PM

Community
Screen Shot 2020-03-25 at 11 00 11 PM

Code of Conduct
Screen Shot 2020-03-25 at 11 00 17 PM

@carolstran
Copy link
Member

Hey hey 👋🏼 FYI - The site was recently migrated to Gatsby (#938) so in order for this to be merged, you'd need to update/rebase the branch and fix the conflicts.

@toshihidetagami
Copy link
Author

thank you for the heads up! I will close this PR and create a new one if I find the time to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants