Skip to content

Forbid duplicate type definitions #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2017
Merged

Forbid duplicate type definitions #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/utilities/__tests__/buildASTSchema-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,4 +802,22 @@ fragment Foo on Type { field }
.to.throw('Specified query type "Foo" not found in document.');
});

it('Forbids duplicate type definitions', () => {
const body = `
schema {
query: Repeated
}

type Repeated {
id: Int
}

type Repeated {
id: String
}
`;
const doc = parse(body);
expect(() => buildASTSchema(doc))
.to.throw('Type "Repeated" was defined more than once.');
});
});
6 changes: 5 additions & 1 deletion src/utilities/buildASTSchema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,12 @@ export function buildASTSchema(ast: DocumentNode): GraphQLSchema {
case ENUM_TYPE_DEFINITION:
case UNION_TYPE_DEFINITION:
case INPUT_OBJECT_TYPE_DEFINITION:
const typeName = d.name.value;
if (nodeMap[typeName]) {
throw new Error(`Type "${typeName}" was defined more than once.`);
}
typeDefs.push(d);
nodeMap[d.name.value] = d;
nodeMap[typeName] = d;
break;
case DIRECTIVE_DEFINITION:
directiveDefs.push(d);
Expand Down