Skip to content

unnecessary call throwing errors #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2016
Merged

Conversation

wenzowski
Copy link
Contributor

Somehow it appears that call is becoming unbound, resulting in errors being thrown by defaultResolveFn.

Why not just call the function directly?

Affects mattkrick/meatier#123 and trace can be seen on ci

Somehow it appears that `call` is becoming unbound resulting in errors
being thrown by `defaultResolveFn`. Why not just call the function
directly?
@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.418% when pulling 2cfe490 on wenzowski:master into 3f6a7f4 on graphql:master.

@wenzowski
Copy link
Contributor Author

This doesn't have a CLA Signed tag yet, but I completed the form.

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@leebyron leebyron merged commit d934068 into graphql:master Mar 24, 2016
@leebyron
Copy link
Contributor

Thanks!

@leebyron
Copy link
Contributor

Oh wait, actually - I'm going to revert this and fix in another way and add tests. The first argument to call is the this context, not the first argument, so this change is not equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants