Skip to content

Allow optionally specifying Args on GraphQLFieldResolver #1197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tgriesser
Copy link
Contributor

Helpful for better type coverage when using tools like apollo-codegen or graphql-code-generator to create field level input argument type definitions.

@tgriesser tgriesser force-pushed the graphql-args-GraphQLFieldResolver branch from b5e057a to 8897f5f Compare January 9, 2018 22:46
@IvanGoncharov
Copy link
Member

@tgriesser Please fix failing npm test command:
https://travis-ci.org/graphql/graphql-js/jobs/327023357#L488

@tgriesser
Copy link
Contributor Author

@IvanGoncharov fixed https://travis-ci.org/graphql/graphql-js/builds/327024762

@leebyron leebyron merged commit 3848c75 into graphql:master Jan 10, 2018
@leebyron
Copy link
Contributor

Cool, nice work!

@tgriesser tgriesser deleted the graphql-args-GraphQLFieldResolver branch January 10, 2018 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants