Works without experimental flow #1157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms, %checks functions cannot themselves call any functions, and function args are presumed to be non-const. This makes changes to re-assure flow, when being used without const_params, that everything is still safe.
mjmahone
commented
Dec 17, 2017
| // experimental.const_params=true is set. | ||
|
|
||
| // isNamedType(type) | ||
| type !== null && |
There was a problem hiding this comment.
!!type && prettiers to Boolean(type) && which is a function call which makes flow fail without experimental.const_params=true. And type && fails because it's not returning a boolean.
There was a problem hiding this comment.
We can probably Boolean wrap the whole expression then. But also it would be great to avoid the additional instanceof checks - we've managed to corral them into their individual predicate functions so far
leebyron
added a commit
that referenced
this pull request
Dec 17, 2017
Merges #1157 Codebases which don't enable this experiment show flow errors
|
I just edited this slightly in #1160 to also remove the flow option so this won't regress, I think it can also avoid needing to inline the other checks |
leebyron
added a commit
that referenced
this pull request
Dec 17, 2017
Merges #1157 Codebases which don't enable this experiment show flow errors
leebyron
added a commit
that referenced
this pull request
Dec 17, 2017
Merges #1157 Codebases which don't enable this experiment show flow errors
leebyron
added a commit
that referenced
this pull request
Dec 17, 2017
Merges #1157 Codebases which don't enable this experiment show flow errors
billydye1
reviewed
May 11, 2018
| // experimental.const_params=true is set. | ||
|
|
||
| // isNamedType(type) | ||
| type !== null && |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For packages that do not use
experimental.const_paramsin their.flowconfig, using v0.12.0 will cause them to have flow errors, as they treat arguments to functions as non-const. This fixes up all of the known cases.To test, comment-out
experimental.const_params=truefrom.flowconfig, and run flow.