Skip to content

Some tests are using floating Promises #2610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dotansimha opened this issue Jun 4, 2020 · 0 comments · Fixed by #2671
Closed

Some tests are using floating Promises #2610

dotansimha opened this issue Jun 4, 2020 · 0 comments · Fixed by #2671

Comments

@dotansimha
Copy link
Member

dotansimha commented Jun 4, 2020 •
edited
Loading

Related to this PR: #2609

Related to execution of graphql (the async version of it) and to subscriptions tests.

(I'll update with link to source one we'll get the TS PR merged)
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this issue Jun 22, 2020
@IvanGoncharov
Added 'executeSync': promise free version of execute.
d214f4a 
Fixes graphql#2610
@IvanGoncharov IvanGoncharov mentioned this issue Jun 22, 2020
Merged
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this issue Jun 22, 2020
@IvanGoncharov
Added 'executeSync': promise free version of execute.
7cc7464 
Fixes graphql#2610
IvanGoncharov added a commit to IvanGoncharov/graphql-js that referenced this issue Jun 22, 2020
@IvanGoncharov
Added 'executeSync': promise free version of execute.
d1cd7ed 
Fixes graphql#2610
IvanGoncharov added a commit that referenced this issue Jun 22, 2020
@IvanGoncharov
Added 'executeSync': promise free version of execute. (#2671)
8f3d09b 
Fixes #2610
@snyk-bot snyk-bot mentioned this issue Apr 17, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added 'executeSync': promise free version of execute. IvanGoncharov/graphql-js
1 participant
@dotansimha