Skip to content

Commit bc33f2e

Browse files
mohawk2leebyron
authored andcommitted
More accurate check for cache-hit in memoize3 (#1207)
`WeakMap.get` returns `undefined` on cache miss. Checking for false instead of `undefined` will give a false cache-miss and recalculate when a false value is returned by the memoised function.
1 parent d518c71 commit bc33f2e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/jsutils/memoize3.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ export default function memoize3<T: (a1: any, a2: any, a3: any) => any>(
2424
cache2 = cache1.get(a2);
2525
if (cache2) {
2626
const cachedValue = cache2.get(a3);
27-
if (cachedValue) {
27+
if (cachedValue !== undefined) {
2828
return cachedValue;
2929
}
3030
}

0 commit comments

Comments
 (0)