This repository was archived by the owner on Mar 20, 2023. It is now read-only.
Allow custom handling of runtime query errors #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthiasKunnen
force-pushed
the
runtime-query-error-handling
branch
from
93b91bb to
ec7d977
Compare
|
I really like this change. Many "batteries included" hosting solutions such as AWS Elastic Beanstalk use the status code for monitoring health. Being able to distinguish between a user error and a network error in the status code would be awesome to make this more accurate. |
acao
approved these changes
Dec 8, 2020
There was a problem hiding this comment.
thank you @MatthiasKunnen! implementation, tests and documentation all look good to me.
|
That's a great addition to the options! Thx you guys! When do you plan to release it? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the earlier PRs were either not ready or not flexible enough I decided to take another shot at this issue.
Closes #427.
Replaces the following PRs:
Closes #471.
Closes #443.