Skip to content

Ci fixes #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2019
Merged

Ci fixes #289

merged 3 commits into from
Nov 10, 2019

Conversation

mathstuf
Copy link
Contributor


Looks like nightly schedules would be nice to catch these kinds of things ahead of time.

Cc: @tomhoule

@mathstuf mathstuf mentioned this pull request Nov 10, 2019
@tomhoule tomhoule mentioned this pull request Nov 10, 2019
@tomhoule
Copy link
Member

I haven't looked into it in detail (I'm in a bit of a rush today) but it looks like only the wasm and rustfmt builds are failing. We'll revisit the wasm/web support soon and we can look at rustfmt at the same time, so you don't have to fix it if you don't have the time. Should I merge?

@mathstuf
Copy link
Contributor Author

It's the clippy checks that are failing. Will amend. The wasm failures can be more easily ignored for now.

@mathstuf
Copy link
Contributor Author

I'll also note that there are better patterns for enforcing formatting of code (namely automatically fixing the problems instead of just informing). You can read some of the details on that process here:

I'm working on a command line variant of it here so that it can be used in GitHub Actions.

@tomhoule
Copy link
Member

I'm very open to doing that in CI!

@mathstuf
Copy link
Contributor Author

Woo! Green.

@mathstuf mathstuf merged commit b54610a into graphql-rust:master Nov 10, 2019
@mathstuf mathstuf deleted the ci-fixes branch November 10, 2019 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants