Skip to content

Move the graphql_client crate to a subdirectory #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 5, 2018
Merged

Move the graphql_client crate to a subdirectory #160

merged 3 commits into from
Oct 5, 2018

Conversation

panicbit
Copy link
Contributor

@panicbit panicbit commented Oct 4, 2018

Fixes #118

@tomhoule
Copy link
Member

tomhoule commented Oct 5, 2018

Thanks for the PR! CI is not passing however. There is a wrong path somewhere apparently.

@panicbit
Copy link
Contributor Author

panicbit commented Oct 5, 2018

Wtf, all tests run fine on my machine D:

@panicbit panicbit closed this Oct 5, 2018
@panicbit panicbit reopened this Oct 5, 2018
@panicbit
Copy link
Contributor Author

panicbit commented Oct 5, 2018

Everything's green now ☺️

@tomhoule
Copy link
Member

tomhoule commented Oct 5, 2018

I merged another PR and now this needs rebasing, sorry :/ I want to do another full review since it's a big change but in principle it looks good.

@panicbit
Copy link
Contributor Author

panicbit commented Oct 5, 2018

Rebased :bowtie:

@tomhoule
Copy link
Member

tomhoule commented Oct 5, 2018

Looks good, thanks for the big PR :)

@tomhoule tomhoule merged commit b4f048d into graphql-rust:master Oct 5, 2018
@panicbit panicbit deleted the issue-118 branch October 5, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panicbit @tomhoule