Skip to content

GeventSubscriptionServer ignore schema validation errors #52

Open
@vodkar

Description

@vodkar
  • GraphQL AioWS version: 0.3.1
  • Python version: Python 3.8.5
  • Operating System: Debian

Description

GeventSubscriptionServer ignore any schema validation errors.
I use Altair GraphQL client. When I send subscription request with schema text errors (for example: wrong field name), this error is covered by GeventSubscriptionServer and just raise "A subscription must return an observable"

I think problem in following lines in gevent.py, line 74:75:

assert isinstance(execution_result, Observable), \ "A subscription must return an observable"

There's check only for Observable, but in case of schema error its return ExecutionResult object with errors, then assert is failed, another error is raising

What I Did

Any subscription query with any schema error

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions