Fixed issue 125, added list_slice_length to default resolver #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sostholm : Great! Thanks for this PR! |
arunsureshkumar
pushed a commit
to arunsureshkumar/graphene-mongo
that referenced
this pull request
Nov 2, 2020
…neConnectionField-paging-is-SLOW Fixed issue 125, added list_slice_length to default resolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello :)
By using the length generated by list_length = iterables.count() in default_resolver and giving it as the argument list_slice_length to connection_from_list_slice, the following code is avoided in connection_from_list_slice (graphql_relay):
if list_slice_length is None:
list_slice_length = len(list_slice)
Looks like this is a very expensive operation for calculating the queryset length.
This reduced the time required to grab the first n objects of a collection of 12000 from +2s to 0.02s.
Passes all tests.