Skip to content

Allow defining fields as an empty list #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2020
Merged

Conversation

jkimbo
Copy link
Member

@jkimbo jkimbo commented Feb 7, 2020

I think it makes sense that if the fields list is defined as an empty list on a DjangoObjectType then no model fields will be selected.

Resolves #864

@jkimbo jkimbo requested review from zbyte64 and syrusakbary February 7, 2020 10:11
@tony
Copy link

tony commented Mar 26, 2020

@jkimbo Nice! Can you rebase this by chance?

@jkimbo jkimbo force-pushed the allow-empty-fields branch from 01b7ef6 to c9386eb Compare May 9, 2020 11:25
@jkimbo jkimbo merged commit 5867331 into master May 9, 2020
@jkimbo jkimbo deleted the allow-empty-fields branch May 9, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to get only_fields = ((),) behavior? Goal: only shows fields declared in object type.
2 participants