Skip to content

resolve django translation deprecation warnings #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2020

Conversation

luto
Copy link
Contributor

@luto luto commented Jan 7, 2020

.../graphene_django/forms/forms.py:11
  .../graphene_django/forms/forms.py:11: RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().
    default_error_messages = {"invalid": _("Invalid ID specified.")}

.../graphene_django/forms/forms.py:33
  .../graphene_django/forms/forms.py:33: RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().
    "invalid_choice": _("One of the specified IDs was invalid (%(value)s)."),

.../graphene_django/forms/forms.py:34
  .../graphene_django/forms/forms.py:34: RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().
    "invalid_list": _("Enter a list of values."),

https://docs.djangoproject.com/en/3.0/releases/3.0/#id3

Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for moving from deprecated functions

@jkimbo jkimbo merged commit 08f6779 into graphql-python:master Jan 11, 2020
@jkimbo
Copy link
Member

jkimbo commented Jan 11, 2020

Thanks @luto !

@luto luto deleted the patch-1 branch January 11, 2020 17:59
@luto
Copy link
Contributor Author

luto commented Jan 11, 2020

Thanks for the quick merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants