django-filter: resolve field along with lookup expression to properly lookup form field #805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #781 , here are somethings I didn't know when I started:
filter.tests.test_filter_filterset_based_on_mixin
(graphene-django/graphene_django/filter/tests/test_fields.py
Line 873 in def6b15
viewer
is virtually mapped to an article as a reporter and is queried asviewer__email__in
. This means we need to power our field lookup withfilter_field.field_name
and not the key name.Another assumption violated is that only the last part specifies nonfield processing, it seems django can now chain some functions into the query, ie:
__lower__first3chars__reversed
https://docs.djangoproject.com/en/2.2/ref/models/lookups/#query-expressionI don't know how our system performs with that feature.