bump graphiql to 0.13.0, and rename __debug to _debug #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

phalt merged 1 commit into graphql-python:master from dulmandakh:graphiql-0.13.0

May 20, 2019

Contributor

dulmandakh commented May 20, 2019

This PR bumps graphiql to 0.13.0, the latest version available on JS CDN, and includes many improvements. And since 0.12 GraphQL prohibits to use names that starts with __, so renamed __debug to _debug. It works for me.

I use graphene-django from master.

fixes #640


          bump graphiql to 0.13.0, and rename __debug to _debug due to __ limit…

49aedf1

…ations

dulmandakh mentioned this pull request

Name "__debug" must not begin with "__", In a future release of graphql this will become a hard error. #640

Closed

coveralls commented May 20, 2019

Coverage remained the same at 92.712% when pulling 49aedf1 on dulmandakh:graphiql-0.13.0 into 74263b2 on graphql-python:master.

4 similar comments

coveralls commented May 20, 2019

Coverage remained the same at 92.712% when pulling 49aedf1 on dulmandakh:graphiql-0.13.0 into 74263b2 on graphql-python:master.

coveralls commented May 20, 2019

Coverage remained the same at 92.712% when pulling 49aedf1 on dulmandakh:graphiql-0.13.0 into 74263b2 on graphql-python:master.

coveralls commented May 20, 2019

Coverage remained the same at 92.712% when pulling 49aedf1 on dulmandakh:graphiql-0.13.0 into 74263b2 on graphql-python:master.

coveralls commented May 20, 2019

Coverage remained the same at 92.712% when pulling 49aedf1 on dulmandakh:graphiql-0.13.0 into 74263b2 on graphql-python:master.

phalt approved these changes

View reviewed changes

Contributor

phalt left a comment

This looks good to me, as you're using this project from master you can attest to it working?

Contributor Author

dulmandakh commented May 20, 2019 •

edited

Loading

@phalt yep, it works for me. I'll open issues or create PRs if I encounter issues.

Contributor

phalt commented May 20, 2019

@dulmandakh thanks for this. I'll ear-mark it for being part of the 2.3 release (still getting the Graphene team to organise how to do this easier).

phalt merged commit 1d1b9e8 into graphql-python:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet