Skip to content

Allow recursive connections with DjangoFilterConnectionField #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 3, 2017

Conversation

tangerilli
Copy link
Contributor

You can't currently create a DjangoFilterConnectionField connection that references its containing node type, because the __init__ method didn't expect the type to be a callable, and even if it did, the callable couldn't return anything at that time, because the type wouldn't be defined yet. These changes move anything that's dependent on the type into properties, so as to defer access until after class initialization.

@coveralls
Copy link

coveralls commented Nov 15, 2016

Coverage Status

Coverage increased (+0.2%) to 92.553% when pulling 207f4eb on tangerilli:recursive-nodes into d8567f1 on graphql-python:master.

@nickhudkins
Copy link
Contributor

@syrusakbary I have submitted a PR to @tangerilli's fork in hopes of avoiding opening another PR here, but hopefully if he accepts, we can get this conflict resolved and merged!

Bring up to date with upstream master
@coveralls
Copy link

coveralls commented Jan 13, 2017

Coverage Status

Coverage increased (+0.2%) to 92.615% when pulling e77962b on tangerilli:recursive-nodes into 4246cea on graphql-python:master.

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage increased (+0.1%) to 92.566% when pulling 9b1c1b4 on tangerilli:recursive-nodes into 4246cea on graphql-python:master.

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage increased (+0.2%) to 92.659% when pulling e82ee88 on tangerilli:recursive-nodes into 4246cea on graphql-python:master.

@austinnichols101
Copy link

Is there any workaround for this issue, or plans to update/integrate this PR?

I'm running into this problem all over the place....

@tangerilli
Copy link
Contributor Author

@austinnichols101 I've resolved the conflicts here

@syrusakbary is there anything you'd like to see changed here in order to get this merged?

@austinnichols101
Copy link

Thanks @tangerilli !

@syrusakbary syrusakbary merged commit acff3d5 into graphql-python:master Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants