-
Notifications
You must be signed in to change notification settings - Fork 767
Allow recursive connections with DjangoFilterConnectionField #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this allows for fields in a node (using a DjangoFilterConnectionField) that reference themselves
@syrusakbary I have submitted a PR to @tangerilli's fork in hopes of avoiding opening another PR here, but hopefully if he accepts, we can get this conflict resolved and merged! |
Bring up to date with upstream master
…lass" This reverts commit 9b1c1b4.
Is there any workaround for this issue, or plans to update/integrate this PR? I'm running into this problem all over the place.... |
@austinnichols101 I've resolved the conflicts here @syrusakbary is there anything you'd like to see changed here in order to get this merged? |
Thanks @tangerilli ! |
You can't currently create a
DjangoFilterConnectionField
connection that references its containing node type, because the__init__
method didn't expect thetype
to be a callable, and even if it did, the callable couldn't return anything at that time, because the type wouldn't be defined yet. These changes move anything that's dependent on the type into properties, so as to defer access until after class initialization.