-
Notifications
You must be signed in to change notification settings - Fork 767
Make GrapheneFilterSetMixin compatible with django-filter 2 #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 if this brings compatibility with django 2.1! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, tested with Django 2 and django-filter 2
@jayhale PR looks great! Just a couple of notes:
|
@synasius thanks. I've:
Hope that closes this one out. Cheers! Tests passed: https://travis-ci.org/jayhale/graphene-django/builds/416952174 - just a stalled build in this workstream |
@jayhale great! LGTM 👍 |
@jayhale Can you trigger the tests again, so that we a have a "green" PR ? |
@sciyoshi I made a nominal change for the sake of re-running the tests. Only those with write-access to the repo are able to restart builds, so it takes a new commit to restart. As an alternative to pushing a new commit, anyone with write access can always restart a build from the Travis build status page for the PR (follow the details link next to the task on GitHub). Glad to be able to help with this one. Thanks for a helpful library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me too 👍
Waiting for a release on this one since its blocking our development! Thanks in advance! |
@b99andla I was in the same situation. |
This should go live, its blocking use of django 2.1 |
@syrusakbary any plans on merging this anytime soon..? |
@jayhale can you resolve the conflicts in |
Merge conflict resolved. |
Pinging @syrusakbary since I can't merge :) |
Would be good to also release a new version after merge :) |
The PR looks great! Merging |
Nice! When can we expect a release to PyPI @syrusakbary ? |
By EOD today or tomorrow :) |
A new version of Graphene Django: Here are the release notes: https://github.com/graphql-python/graphene-django/releases/tag/v2.2.0 |
To support
Django >=2
graphene-django
must supportdjango-filter >=2
.Changes made:
graphene_django.filter.GlobalIDFilter
to handle cases when the filter value isNone
.filter_for_reverse_field()
fromgraphene_django.filter.GrapheneFilterSetMixin
filter_for_reverse_field()
tographene_django.filter.GrapheneFilterSetMixin
only for cases whendjango-filter <2
setup.py
toDjango >=1.11
anddjango-filter >=2
forpython ==3
anddjango-filter >=1
forpython ==2
Django <1.9
from graphene_django/tests/test_converter.pyJSONField
in compat.pyexamples/cookbook
django-filter
documentation indocs/filtering.rst
All tests pass.
Resolves: #484
Resolves: #464
Related: #491