Make GrapheneFilterSetMixin compatible with django-filter 2

[jayhale]

To support Django >=2 graphene-django must support django-filter >=2.

Changes made:

• Revised graphene_django.filter.GlobalIDFilter to handle cases when the filter value is None.
• Removed filter_for_reverse_field() from graphene_django.filter.GrapheneFilterSetMixin
• Added back filter_for_reverse_field() to graphene_django.filter.GrapheneFilterSetMixin only for cases when django-filter <2
• Updated requirements in setup.py to Django >=1.11 and django-filter >=2 for python ==3 and django-filter >=1 for python ==2
• Removed unnecessary checks for Django <1.9 from graphene_django/tests/test_converter.py
• Removed separate check for JSONField in compat.py
• Updated requirements in examples/cookbook
• Updated links to django-filter documentation in docs/filtering.rst

All tests pass.

Resolves: #484
Resolves: #464

Related: #491

[coveralls]

Coverage decreased (-0.08%) to 94.583% when pulling 0314931 on jayhale:django-filter-2 into 14f156e on graphql-python:master.

[phalt]

👍 if this brings compatibility with django 2.1!

[afriapps]

This works, tested with Django 2 and django-filter 2

[synasius]

@jayhale PR looks great! Just a couple of notes:

• Django 1.11 is still supporting Python 2 so you should not remove Python 2.7 from the test matrix. Instead you should add to the matrix Django 1.11 and Python 2 and 3. See https://docs.djangoproject.com/en/2.0/releases/1.11/#python-compatibility
• Since you removed support for Django < 1.11 (which is good 👍 ) you should clean the graphene_django/compat.py module. See here for more details https://coveralls.io/builds/18371679/source?filename=graphene_django%2Fcompat.py#L16

[jayhale]

@synasius thanks. I've:

• Added back a test case for Python 2.7 and Django 1.11
• Added back linting for Python 2.7 (rules appear to hit differently whether I'm on 2.7 or 3.x, so including both)
• Removed unnecessary checks for Django < 1.9 from graphene_django/tests/test_converter.py
• Removed separate check for JSONField in compat.py
• Fixed a typo in a link I updated in the filtering docs (all correct now)

Hope that closes this one out. Cheers!

---

Tests passed: https://travis-ci.org/jayhale/graphene-django/builds/416952174 - just a stalled build in this workstream

[synasius]

@jayhale great! LGTM 👍

[synasius]

@jayhale Can you trigger the tests again, so that we a have a "green" PR ?

[jayhale]

@sciyoshi I made a nominal change for the sake of re-running the tests.

Only those with write-access to the repo are able to restart builds, so it takes a new commit to restart. As an alternative to pushing a new commit, anyone with write access can always restart a build from the Travis build status page for the PR (follow the details link next to the task on GitHub).

Glad to be able to help with this one. Thanks for a helpful library.

[eieste]

Works for me too 👍

[b99andla]

Waiting for a release on this one since its blocking our development! Thanks in advance!

[ValentinCreative]

@b99andla I was in the same situation.
I temporarily put this in my requirements.txt
git+https://github.com/jayhale/graphene-django.git@django-filter-2#egg=graphene-django
Instead of graphene-django
So I'm able to continue developments, if it can help :)

[aldarund]

This should go live, its blocking use of django 2.1

[aldarund]

@syrusakbary any plans on merging this anytime soon..?

[patrick91]

@jayhale can you resolve the conflicts in docs/filtering.rst?

[jayhale]

Merge conflict resolved.

[patrick91]

Pinging @syrusakbary since I can't merge :)

[aldarund]

Would be good to also release a new version after merge :)

[syrusakbary]

The PR looks great! Merging

[jckw]

Nice! When can we expect a release to PyPI @syrusakbary ?

[syrusakbary]

By EOD today or tomorrow :)

[syrusakbary]

A new version of Graphene Django: 2.2.0 is now on PyPI.

Here are the release notes: https://github.com/graphql-python/graphene-django/releases/tag/v2.2.0