-
Notifications
You must be signed in to change notification settings - Fork 766
models.DateField => graphene Date Scalar #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2 similar comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
The change to use Date
instead of DateTime
makes a lot of sense now that upstream Graphene has added that type.
There is a separate PR handling the change to support Django 2.0 in tests (#336). So if you could slim this PR down to just the Date
changes, that would be great.
Then, since this will cause a change in existing behavior, we need to make sure it goes behind a version bump.
Hi @spockNinja |
Thanks @urbandove! @syrusakbary This update looks good to me. I'm not too sure how you want to handle version bumps when something breaks existing functionality (but is still a general improvement). @urbandove has bumped the version in this PR, but if that's not the version workflow you follow, we can undo that. In my review, I was just making a note of the need for a bump in general (before it goes to pypi), not necessarily in this PR. |
Currently models.DateField is processed as a DateTime Scalar - this changes it to the new Date Scalar added to graphene
Please note - that the test pass on Django 1.11 - but i was having erros crop up on django 2.0 (1 related to pytest dependancy and the rest was an issue of foreignkeys missing the rel attribute - which i dont think is caused by this)