Skip to content

Read CSRF token from DOM instead of cookie #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Read CSRF token from DOM instead of cookie #308

wants to merge 1 commit into from

Conversation

nealedj
Copy link

@nealedj nealedj commented Oct 30, 2017

Fixes #307

@coveralls
Copy link

coveralls commented Oct 30, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 92.999% when pulling 189a586 on nealedj:patch-1 into 2600f0f on graphql-python:master.

@syrusakbary
Copy link
Member

Would be great to support both (start with cookie and fallback to the input) instead of using only one.

@jplock jplock mentioned this pull request Sep 9, 2018
Merged
@phalt
Copy link
Contributor

phalt commented May 3, 2019

I'd like to tidy up some of the PRs, so if we still want to work on this let me know or I will close this in 1 week.

@dulmandakh
Copy link
Contributor

LGTM. @nealedj could you please rebase or resolve the conflict.

@phalt phalt closed this May 23, 2019
@cbergmiller cbergmiller mentioned this pull request Dec 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changes requested ✨enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GraphQLView fails when using session CSRF
5 participants
@nealedj @coveralls @syrusakbary @phalt @dulmandakh