Pass context object to FilterSet for request-baed filtering #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
force-pushed
the
master
branch
2 times, most recently
from
bdc7189 to
f93251b
Compare
|
Is there anything I can do to help getting this PR merged? |
spockNinja
approved these changes
Sep 30, 2017
|
@syrusakbary As the added docs show, this is supported by django-filter. It is a simple addition that will improve the django-filter/DRF integration. The test covers the new functionality and everything looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing the context object to the filter set instance (it's called a request object inside a
FilterSetinstance).I've added an additional test and updated the documentation.
It should fix #203.