Skip to content

Revert "fix: unit test for graphene pr#1412" #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Revert "fix: unit test for graphene pr#1412" #1350

wants to merge 1 commit into from

Conversation

firaskafri
Copy link
Collaborator

@firaskafri firaskafri commented Sep 23, 2022 •
edited
Loading

Reverts #1315 due changes in setup.py that probably broke tests

erikwrede
erikwrede reviewed Sep 24, 2022
View reviewed changes
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be more elegant to push a fix to setup.py instead of reverting the entire PR and reopening it without the changes to setup.py?

@firaskafri firaskafri closed this Sep 24, 2022
@firaskafri
Copy link
Collaborator Author

Wouldn't it be more elegant to push a fix to setup.py instead of reverting the entire PR and reopening it without the changes to setup.py?

#1352

@erikwrede Thank you!

@firaskafri firaskafri deleted the revert-1315-users/tcleonard/fix-test-for-graphene-PR#1412 branch September 24, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikwrede erikwrede erikwrede left review comments

@tcleonard tcleonard Awaiting requested review from tcleonard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firaskafri @erikwrede