DjangoObjectType duplicate models breaks Relay node resolution

[nickhudkins]

If you define the following two types, or types that follow this pattern (Same model, different names). The relay node resolver resolves the incorrect name (and therefore incorrect globalID) for the type registered 2nd.

class ThingA(DjangoObjectType):
    class Meta:
        model = Thing
        name = 'ThingA'
        interfaces = (relay.Node, )

class ThingB(DjangoObjectType):
    class Meta:
        model = Thing
        name = 'ThingB'
        interfaces = (relay.Node, )

Query (ThingA globalID) :

{
  node(id: "GhpbmdBOjE=") {
    id // "GhpbmdBOjE=" Correct!
  }
}

Query (ThingB globalID)

{
  node(id: "VGhpbmdCOjE=") {
    id // "GhpbmdBOjE=" Incorrect :(
  }
}

It appears that there is some commented out code to warn about this. However, it is commented out so I am unsure what the intention of the author was.

I am really just looking to see if this is "as designed". @syrusakbary

[syrusakbary]

Right now you can make this work with using a new registry for the second definition.

from graphene_django.registry import Registry

class ThingB(DjangoObjectType):
    class Meta:
        #
        registry = Registry()

Also, this issue #104 might be related :)

[aliektlee]

Right now you can make this work with using a new registry for the second definition.

from graphene_django.registry import Registry

class ThingB(DjangoObjectType):
    class Meta:
        #
        registry = Registry()

Also, this issue #104 might be related :)

Hi @syrusakbary ,

May i know how to implement the below structure and make it works, thank you very much.

model:

class A(models.Model):
    field1 = models.CharField()
    field2 = models.CharField()

class B(models.Model):
    a = models.ForeignKey(A)

scheme type:

class AType1(DjangoObjectType):
    class Meta:
        model = A
        only_fields = 'field1'

class AType2(DjangoObjectType):
    class Meta:
        model = A
        only_fields = 'field2'


class BType1(DjangoObjectType):
    class Meta:
        model = B
        only_fields = ('a__field1')  // just return the foreign object field1

class BType2(DjangoObjectType):
    class Meta:
        model = B
        only_fields = ('a__field2')  // just return the foreign object field2

class Query(graphene.ObjectType):
    b1 = graphene.List(BType1)
    b2 = graphene.List(BType2)
    ...

[matt-dalton]

None of the solutions above seem to work any more - I am on graphene==2.1.8 and graphene-django==2.11.0

Does anyone have any suggestions of what else I can try? This is currently blocking a fairly major feature for us.

Specifically I'm trying to get this query to output the same IDs for users and publicUsers:

{
   viewer {
       users {
          id
       }
       publicUsers {
          id
       }
   }
}

where

class PublicUser(DjangoObjectType):
    class Meta:
        model = UserModel
        interfaces = (graphene.relay.Node,)

class User(DjangoObjectType):
    class Meta:
        model = UserModel
        interfaces = (graphene.relay.Node,)