Skip to content

Trapping dependencies Exceptions into TransportConnectionFailed #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

Breaking Change

This PR modifies the transports to trap exceptions when trying to use the underlying dependency post method.

Before, if an SSL error was received, you would get:

  • SSLError with requests
  • ClientConnectorCertificateError with aiohttp
  • ConnectError with httpx

Now, in all cases your will receive a TransportConnectionFailed Exception with the same message as before.

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7fb869a) to head (96b4f03).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #558    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           38        40     +2     
  Lines         2908      3116   +208     
==========================================
+ Hits          2908      3116   +208     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszekhanusz leszekhanusz changed the title Feature trapping dependencies Exceptions into TransportConnectionFailed Trapping dependencies Exceptions into TransportConnectionFailed May 28, 2025
@leszekhanusz leszekhanusz merged commit 4af703e into graphql-python:master May 28, 2025
15 checks passed
@leszekhanusz leszekhanusz deleted the feature_using_transport_connection_failed_exception branch May 28, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant