Skip to content

Refactor transports #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

leszekhanusz
Copy link
Collaborator

  • split requests transport in private methods similarly than the aiohttp and httpx transport
  • remove the _prepare_batch_request method and use _prepare_request instead for batch requests to avoid code duplication

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7fb869a) to head (eaf6d1b).
Report is 20 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #557    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           38        40     +2     
  Lines         2908      3092   +184     
==========================================
+ Hits          2908      3092   +184     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszekhanusz leszekhanusz merged commit 4fa1553 into graphql-python:master May 28, 2025
15 checks passed
@leszekhanusz leszekhanusz deleted the refactor_requests_transport branch May 28, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant