Skip to content

Using GraphQLRequest instead of DocumentNode for gql, execute, subscribe methods #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

@leszekhanusz leszekhanusz commented May 28, 2025

Breaking change:

  • gql and dsl_gql methods now returns a GraphQLRequest instead of a DocumentNode
  • all execute and subscribe methods of Client and sessions now expects a GraphQLRequest instead of a DocumentNode

A GraphQLRequest is an object which contains optional variable_values and operation_name in addition to the document.

Because of that double change, the simple code examples do not need to be changed, but if you're using external methods on the result from the gql method, like print_ast which expects a DocumentNode, then you will need to use the document attribute of the request.

Before:

query = gql("{balance}")
print_ast(query)

After:

query = gql("{balance}")
print_ast(query.document)

Deprecated variable_values and operation_name in execute and subscribe methods

The new way to add variable_values is to set it as a property of the GraphQLRequest, and not as an argument of execute or subscribe methods:

    query = gql(
        """
        query getContinentName ($code: ID!) {
          continent (code: $code) {
            name
          }
        }
    """
    )

    query.variable_values = {"code": "EU"}

    # Get name of continent with code "EU"
    result = client.execute(query)

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7fb869a) to head (4ef394d).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##            master      #556    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           38        40     +2     
  Lines         2908      3103   +195     
==========================================
+ Hits          2908      3103   +195     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszekhanusz leszekhanusz merged commit b3789ef into graphql-python:master May 28, 2025
15 checks passed
@leszekhanusz leszekhanusz deleted the refactor_using_graphql_request_as_main_argument branch May 28, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant