change transports prototype using GraphQLRequest #551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everywhere in the code we are sending the
document
,variable_values
andoperation_name
as arguments of the methods.Now that we have a
GraphQLRequest
class which encapsulate those properties, it makes sense to use it instead.Simplifying transport
execute
andsubscribe
methods prototypes by using aGraphQLRequest
object intead ofdocument
,variable_values
andoperation_name
Potential breaking changes:
variable_values
andoperation_name
are now keyword arguments only inclient.py
:you cannot do
client.execute(query, params)
anymore and need to doclient.execute(query, variable_values=params)
insteadexecute
andsubscribe
prototype to conform to the new methods.