Skip to content

Fix task cancel exception swallow #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

@leszekhanusz leszekhanusz commented May 20, 2025

Cancelling a subscription task should generate a CancelledError Exception as explained in issue #544

This PR fixes this problem.

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7fb869a) to head (f66008e).
Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #548   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2908      2855   -53     
=========================================
- Hits          2908      2855   -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszekhanusz leszekhanusz merged commit 9a84f0b into graphql-python:master May 20, 2025
15 checks passed
@leszekhanusz leszekhanusz deleted the fix_task_cancel_exception_swallow branch May 20, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant