Skip to content

Upgrade lastest websockets and Exceptions overhaul #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

leszekhanusz
Copy link
Collaborator

@leszekhanusz leszekhanusz commented Mar 12, 2025

  • Using new asyncio implementation of the websockets dependency.
  • Bump websockets to >=14.2
  • Reduced some timers to make tests faster.
  • Now the reconnecting session will reconnect as soon as it detects that the connection failed.
  • Better log messages
  • using TransportConnectionFailed instead of TransportClosed for exceptions which were due to the connection failing or closing. Using TransportClosed only for a closing of the transport initiated by the user.

Using new websockets asyncio implementation
Now the reconnecting session will reconnect as soon as it detects
that the connection failed.

Better log messages
Copy link

codecov bot commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7fb869a) to head (cc3c3dd).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #543   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         2908      2856   -52     
=========================================
- Hits          2908      2856   -52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leszekhanusz leszekhanusz changed the title Chore upgrade lastest websockets Upgrade lastest websockets and Exceptions overhaul Mar 14, 2025
leszekhanusz

This comment was marked as off-topic.

@leszekhanusz leszekhanusz merged commit 886a6b8 into graphql-python:master Mar 14, 2025
15 checks passed
@leszekhanusz leszekhanusz deleted the chore_upgrade_lastest_websockets branch March 14, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant