-
Notifications
You must be signed in to change notification settings - Fork 184
Feat: Add Streaming functionalities to file uploads #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add Streaming functionalities to file uploads #174
Conversation
Thanks for your PR, that's definitely something I wanted to add. Could you please:
|
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 946 949 +3
=========================================
+ Hits 946 949 +3
Continue to review full report at Codecov.
|
I have embedded your suggestions into the code. |
Looks good! What I would also like to integrate in this PR is the possibility to send large local files using an asynchronous generator as described here. Then we would need some test for those two functionalities. |
Thanks, I'll do it on the weekend |
Very nice! I just made some small modifications to the docs but cannot push it here. |
Thanks! The checkbox in the "Allow maintainers to edit" field was already there, I rearranged it again. Or need to do something else? |
It seems to work now... I've added my modifications. |
When I try this
I get an error: |
When receiving a large file from a request(use aiohttp) and then transferring it through Graphql, it was necessary to read the data from the request and we can load it into RAM or save it to disk (to avoid memory leaks), and only after that it was possible to transfer it through graphql(use io.BytesIO or open()). In this branch, I tried to solved this problem.