-
Notifications
You must be signed in to change notification settings - Fork 184
Optional dependencies for transports #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional dependencies for transports #158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #158 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 941 941
=========================================
Hits 941 941
Continue to review full report at Codecov.
|
Of course we'll need to document this before it is merged as it is a breaking change. |
I'm starting to think that my PR #112 was actually a bad idea. We could still revert it as we are still in alpha? |
Seems to be the same setup as I did at graphql-server but I am curious about the usage of with supress statement in order to keep running the program if the user has not installed any "required" extras. Regarding PR #112, well since you want to alert users to install required packages in order to use specific transports, the export should be keep on the same module scope, in other words, with this change it should avoid including all transports on global export ( |
That's because I copied it from there 😆 |
@leszekhanusz are you going to revert the #112 on this PR so it is two birds, one shot? 👓 |
Yes |
I modified the tests so that you can run tests with only a single transport dependency.
to install test dependencies for only websockets for example:
|
Now I still need to add GitHub actions to test this automatically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 🚀
See issue #147